dbeaver/pro#10195 Refactor editor properties to always be strings - #4595
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
🟢 Approval recommended
The API narrowing is consistently applied across the shown service and controller layers and matches the GraphQL contract for rmSetResourceProperty(value: String).
Pull request overview
Updates the Resource Manager backend API to treat resource/editor properties as strings only, aligning the Java service/controller signatures with the existing GraphQL schema (value: String) and reducing ambiguity around property typing.
Changes:
- Narrowed
setResourcePropertyparameter type fromObjecttoStringin the RM web service API and implementation. - Narrowed resource properties map typing from
Map<String, Object>toMap<String, String>in the local RM controller flow. - Updated the copyright header year in
DBWServiceRM.java.
File summaries
| File | Description |
|---|---|
| server/bundles/io.cloudbeaver.service.rm/src/io/cloudbeaver/service/rm/impl/WebServiceRM.java | Changes setResourceProperty to accept a nullable String value and forwards it to the controller. |
| server/bundles/io.cloudbeaver.service.rm/src/io/cloudbeaver/service/rm/DBWServiceRM.java | Updates the service contract for setResourceProperty to use @Nullable String and refreshes the header year. |
| server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/model/rm/local/LocalResourceController.java | Switches property value and properties map typing to String for RM property update and resource construction paths. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are a straightforward type-contract alignment across the RM service and controller layers with no additional issues found in the modified hunks.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
…ro#10195-editor-properties-refactor
No description provided.